Issue3618 air filter #3676
Issue3618 air filter #3676
Conversation
Issue3618 air filter
|
@SenHuang19 See inline comments. |
Issue3618 air filter
|
|
This is ready for final review by Jianjun. |
Issue3618 air filter
| "Filtration efficiency of each contaminant" | ||
| annotation (Placement(transformation(extent={{100,-80},{140,-40}}))); | ||
| Buildings.Controls.OBC.CDL.Interfaces.RealOutput rat( | ||
| final unit="1", |
There was a problem hiding this comment.
In this class, the rat is a scale variable, while in class Buildings.Fluid.AirFilters.BaseClasses.Characteristics.FiltrationEfficiencyParameters, the rat is a vector. Are they same or different?
Through commit e746684, I removed each declaration. Is it a correct change? As in Modelica, each should only be used by the vector variable declaration.
There was a problem hiding this comment.
Buildings.Fluid.AirFilters.BaseClasses.FilterationEfficiency defines rat while in Buildings.Fluid.AirFilters.BaseClasses.Characteristics.FiltrationEfficiencyParameters, we declare a list of rat and each rat corresponds to a specific type of containment. Should I rename the rat in Buildings.Fluid.AirFilters.BaseClasses.Characteristics.FiltrationEfficiencyParameters to avoid confusions?
| </li> | ||
| <li> | ||
| how the filtration efficiency changes along with the contaminant accumulation, | ||
| specific to each type. |
There was a problem hiding this comment.
each type of what? is it each type of the contaminant? I wonder if this bullet refers to the per.filEffPar?
There was a problem hiding this comment.
each type of containment, yes, it refers to per.filEffPar. I will improve the whole document section to avoid confusion.
| the types of contaminants can be captured by the filter; | ||
| </li> | ||
| <li> | ||
| how the flow coefficient changes as contaminants build up; |
There was a problem hiding this comment.
Does it refer to per.b?
This closes #3618.