Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize Dockerfile and implement CI/CD to DockerHub #45

Merged
merged 3 commits into from
Aug 16, 2021
Merged

Optimize Dockerfile and implement CI/CD to DockerHub #45

merged 3 commits into from
Aug 16, 2021

Conversation

EONRaider
Copy link
Contributor

@EONRaider EONRaider commented Aug 11, 2021

This PR fixes and modifies the Dockerfile in GAU with the following considerations:

  • The current Dockerfile does not leverage multi-stage builds. The current image has about 868MB with the current Dockerfile instructions. With multi-stage build it has about 16MB.
  • Adds deterministic base images for reproducible builds.
  • Added a least-privileged user in compliance with Docker security best practices.

We also have a workflow with a CICD pipeline to DockerHub. All you need to do is to add the DOCKER_HUB_USERNAME and DOCKER_HUB_ACCESS_TOKEN secrets to the repository and all pushes/merges to the master branch will automatically push an image to DockerHub.

@lc lc merged commit 0c4b6aa into lc:master Aug 16, 2021
@lc
Copy link
Owner

lc commented Aug 16, 2021

lgtm! thanks for the PR ✌🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants