Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get macOS test working again #2502

Closed
wants to merge 1 commit into from
Closed

Conversation

certik
Copy link
Contributor

@certik certik commented Feb 7, 2024

Towards #2455.

The first macOS failure in master happened in #2452. This PR reverts LPython to the commit before that. We'll see if it reliably passes.

If it passes, then #2452 must have broken it.

If it doesn't pass, then something in the GitHub Actions or Conda environment changed.

@certik
Copy link
Contributor Author

certik commented Feb 7, 2024

It hangs.... So the issue is definitely not caused by #2452. Rather, it's either caused by something introduced before that PR, or some changes in the GitHub Actions or Conda environments.

@certik
Copy link
Contributor Author

certik commented Feb 7, 2024

Testing an even older commit at #2504

@certik
Copy link
Contributor Author

certik commented Feb 9, 2024

We figured it out in #2520.

@certik certik closed this Feb 9, 2024
@certik certik deleted the macos_test branch February 9, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant