Weather widget - day/time in UTC #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull changes from origin
|
Not working for me: it gives a nightly icon, while it's AM here. |
|
Hmm, on my 3 computers it works properly. I've added some debug output: https://github.com/trap000d/lain/blob/debug/widget/weather.lua |
2017-09-07 17:51:55 W: awesome: Times:1504799515 3600 1504845358 1504891431 1504735200 1504731600
2017-09-07 17:51:55 W: awesome: Weather icon:11nIcon is |
|
After looking at your logs... Well... I've forgotten of DST. Also I've tried to optimize code a bit. Here the debug version. Please test if it works on your machine. |
|
It's OK now. Remove debugs, Wiki has to be updated too. |
|
OK. 59f99ea |
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
utc_offset option/function is not need anymore