-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Components & presentations #1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This looks awesome |
EdAyers
reviewed
Jan 10, 2023
Vtec234
force-pushed
the
presentations
branch
from
February 2, 2023 04:10
c38dd77
to
0e62d07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a type
Component Props
which gives a Lean type to the props of a React component.Add capability to store
RpcEncodable
widget props in theInfoTree
(viaofCustomInfo
but we could add it to core Lean later). SeeCompat.lean
for implementation details.Support using widget components inline in JSX syntax so we can partly describe GUIs in pure Lean, kind of like ProofWidgets4. JS still needs to be written for any kind of event handling or RPC call.
Add a component to display Penrose diagrams.
Introduce a framework for displaying
Expr
s as interactive widgets from Lean code. AnExpr
presenter registered with@[expr_presenter]
is similar to a delaborator but outputs HTML trees instead of syntax, and the output HTML can contain elements which interact with the originalExpr
in some way. We call interactive outputs with a reference to the original input presentations following [Ciccarelli].An example presenter looks like
Depends on leanprover/lean4#1969 and the associated vscode-lean4 PR.