Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

leanchecker should print french quotes #114

Open
fpvandoorn opened this issue Feb 17, 2020 · 5 comments
Open

leanchecker should print french quotes #114

fpvandoorn opened this issue Feb 17, 2020 · 5 comments
Labels
bug Something isn't working

Comments

@fpvandoorn
Copy link
Member

... if a component of a name contains a period. See isabelle-prover/proving-contest-backends#27

@fpvandoorn
Copy link
Member Author

Ideally the code snippet in isabelle-prover/proving-contest-backends#27 (comment) should result in

«quot.sound» : ∀ {α : Sort u} {r : α → α → Prop} {a b : α}, r a b → «quot.mk» r a = «quot.mk» r b

with French quotes both around the name and around the type.

Note that #print and #print axioms in Lean put french quotes around ambiguous names in the type, but not around the name of the declaration you're printing. That could be improved, too.

@kappelmann
Copy link

Having no clue about any of the Lean cpp infrastructure, is this something that should be fixed globally in declaration.cpp or locally in checker.cpp?

@Kha
Copy link
Contributor

Kha commented Feb 19, 2020

Locally in pp_name -- compare with https://github.com/leanprover/lean/blob/master/src/util/name.cpp#L58

@kappelmann
Copy link

kappelmann commented Jun 18, 2020

@gebner Thanks for dealing with this. I just wanted to adapt our proving contest backend and think that there is still some issue.
The program

axiom «quot.sound : a» : false
theorem my_proof : false := «quot.sound : a»

and

axiom «quot.sound» : false
theorem my_proof : false := «quot.sound»

return the same warning, i.e. "WARNING: Unknown axiom '«quot.sound»' used to prove theorem....
Seems like : <string> will be chopped off from quoted names?

@gebner
Copy link
Member

gebner commented Jun 18, 2020

Seems like : <string> will be chopped off from quoted names?

This is a bug in the text export parser of leanchecker.

@gebner gebner reopened this Jun 18, 2020
@bryangingechen bryangingechen added the bug Something isn't working label Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants