Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: Matrix.PosDef (A + B) and Matrix.PosSemidef (A + B) #13750

Closed
wants to merge 1 commit into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Jun 12, 2024

@eric-wieser eric-wieser added awaiting-author A reviewer has asked the author a question or requested changes awaiting-CI labels Jun 12, 2024
Copy link

github-actions bot commented Jun 12, 2024

PR summary f5c4619278

Import changes

No significant changes to the import graph


Declarations diff

+ add_posSemidef
+ posSemidef_add
++ add

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) and removed merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) labels Jun 12, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) and removed merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) labels Jun 17, 2024
@eric-wieser eric-wieser force-pushed the eric-wieser/posDef_add branch from 71aa442 to e0ee1e9 Compare June 19, 2024 22:34
@eric-wieser eric-wieser changed the title feat: Matrix.PosDef (A + B) and Matrix.PosDef 1 feat: Matrix.PosDef (A + B) and Matrix.PosSemidef (A + B) Jun 19, 2024
@eric-wieser eric-wieser force-pushed the eric-wieser/posDef_add branch from e0ee1e9 to 5067b47 Compare June 20, 2024 23:04
@eric-wieser eric-wieser force-pushed the eric-wieser/posDef_add branch from 5067b47 to f5c4619 Compare June 20, 2024 23:05
@eric-wieser eric-wieser added awaiting-review t-algebra Algebra (groups, rings, fields, etc) and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jun 20, 2024
@dupuisf
Copy link
Contributor

dupuisf commented Jun 24, 2024

Thanks!

bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jun 24, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jun 24, 2024
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jun 24, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: Matrix.PosDef (A + B) and Matrix.PosSemidef (A + B) [Merged by Bors] - feat: Matrix.PosDef (A + B) and Matrix.PosSemidef (A + B) Jun 24, 2024
@mathlib-bors mathlib-bors bot closed this Jun 24, 2024
@mathlib-bors mathlib-bors bot deleted the eric-wieser/posDef_add branch June 24, 2024 15:14
kbuzzard pushed a commit that referenced this pull request Jun 26, 2024
dagurtomas pushed a commit that referenced this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants