feat(Computability/EpsilonNFA): define path relation #20645
+126
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonyde
added
the
t-computability
github-actions
bot
added
the
new-contributor
|
messageFile.md |
mathlib4-dependent-issues-bot
added
the
blocked-by-other-PR
2 tasks
mathlib4-dependent-issues-bot
removed
the
blocked-by-other-PR
|
This PR/issue depends on: |
YaelDillies
reviewed
Jan 17, 2025
YaelDillies
added
the
awaiting-author
|
Thanks for the review. I applied your suggestions generally. |
anthonyde
removed
the
awaiting-author
YaelDillies
reviewed
Jan 19, 2025
YaelDillies
added
the
awaiting-author
`Path` enables path-based reasoning in proofs involving `εNFA`.
Theorems were renamed.
Theorems are renamed to use `snake_case` and remove `_iff` suffixes, and arguments are made implicit. `@[simp]` is also added where applicable.
`IsPath` is more appropriate for a `Prop` definition. Related theorems are also renamed.
anthonyde
force-pushed
the
anthonyde/enfa-path
branch
from
f8daea2 to
fee8650
Compare
PR summary 2cbaadd9f9
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Computability.EpsilonNFA | 684 | 685 | +1 (+0.15%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.Computability.EpsilonNFA |
1 |
Declarations diff
+ IsPath
+ IsPath.eq_of_nil
+ IsPath.singleton
+ isPath_append
+ isPath_nil
+ isPath_singleton
+ mem_accepts_iff_exists_path
+ mem_evalFrom_iff_exists
+ mem_evalFrom_iff_exists_path
+ mem_εClosure_iff_exists
+ mem_εClosure_iff_exists_path
++ _
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
|
I applied your suggestions and rebased to remove merged changes from the diff. I'll open another PR for the changes in |
anthonyde
removed
the
awaiting-author
YaelDillies
reviewed
Jan 21, 2025
YaelDillies
added
the
awaiting-author
Some `tauto` occurrences are replaced by `exact` with named variables.
YaelDillies
reviewed
Jan 21, 2025
anthonyde
removed
the
awaiting-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IsPathenables path-based reasoning in proofs involvingεNFA.