Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add question mark to LEAN_IDENT_RE #1713

Merged
merged 2 commits into from
Oct 11, 2022
Merged

doc: add question mark to LEAN_IDENT_RE #1713

merged 2 commits into from
Oct 11, 2022

Conversation

lovettchris
Copy link
Contributor

See https://leanprover.github.io/lean4/doc/functions.html

Without this fix:
image

The question mark is highlighted in a way that sends a confusing message to the user that the question mark is NOT part of the name - but it is just part of the name.

With this fix:

image

@digama0
Copy link
Collaborator

digama0 commented Oct 10, 2022

You added ? as an initial identifier character though, which is not correct: e.g. ?a is not an identifier (it is a named metavariable). ? is legal as a trailing identifier character.

@lovettchris
Copy link
Contributor Author

Woops good catch - I pushed a fix.

@Kha Kha merged commit 664e62e into leanprover:master Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants