Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid syntax stack copy at orelseFn #2306

Merged
merged 2 commits into from
Jul 28, 2023
Merged

Avoid syntax stack copy at orelseFn #2306

merged 2 commits into from
Jul 28, 2023

Conversation

Kha
Copy link
Member

@Kha Kha commented Jul 4, 2023 •
edited
Loading

This fixes a silly oversight on my part in #1272

@Kha
Copy link
Member Author

Kha commented Jul 4, 2023

!bench

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit 621bb02.
There were significant changes against commit aee9ce4:

  Benchmark   Metric       Change
  =========================================
+ liasolver   task-clock    -1.7% (-15.5 σ)
+ liasolver   wall-clock    -1.7% (-15.8 σ)

@leodemoura leodemoura self-assigned this Jul 10, 2023
@leodemoura leodemoura added the awaiting-review Waiting for someone to review the PR label Jul 10, 2023
@leodemoura leodemoura merged commit 8fc1af6 into leanprover:master Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@leodemoura leodemoura

Labels
awaiting-review Waiting for someone to review the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kha @leanprover-bot @leodemoura