Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: tune Array.push runtime code #6471

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

hargoniX
Copy link
Contributor

@hargoniX hargoniX commented Dec 29, 2024

The current condition for the shared branch fires too often.

@hargoniX
Copy link
Contributor Author

!bench

@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc December 29, 2024 11:29 Inactive
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Dec 29, 2024
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 844e82e176f497798de42973c14f65856bad45be --onto fe45ddd6105078a0a3bd855e5d94673e794f6b88. (2024-12-29 11:33:39)

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit 6790707.
There were significant changes against commit 844e82e:

  Benchmark             Metric                  Change
  ==============================================================
+ binarytrees           task-clock               -3.7% (-12.6 σ)
+ bv_decide_realworld   task-clock               -1.9% (-49.2 σ)
+ const_fold            task-clock               -3.3% (-11.3 σ)
+ const_fold            wall-clock               -3.3% (-11.1 σ)
+ simp_arith1           wall-clock               -3.8% (-32.1 σ)
+ stdlib                attribute application    -1.4% (-28.9 σ)
- stdlib                dsimp                     1.4% (925.1 σ)

@hargoniX
Copy link
Contributor Author

!bench

@hargoniX hargoniX changed the title perf: dont expand shared arrays too often perf: tune Array.push runtime code Dec 29, 2024
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc December 29, 2024 11:51 Inactive
@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit 0cd8829.
There were significant changes against commit 844e82e:

  Benchmark   Metric          Change
  ============================================
+ big_do      branch-misses    -8.1% (-43.7 σ)
+ big_do      maxrss           -1.1% (-17.5 σ)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants