Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code actions, to "fill holes" with suggestions from Lean Language Server #45

Closed
lovettchris opened this issue Oct 8, 2021 · 4 comments
Closed

Code actions, to "fill holes" with suggestions from Lean Language Server #45

lovettchris opened this issue Oct 8, 2021 · 4 comments
Assignees
@lovettchris
Labels
nice to have It would be great to have or fix, but it is not essential.

Comments

@lovettchris
Copy link
Contributor

lovettchris commented Oct 8, 2021 •
edited
Loading

Need server to provide nice text spans so there's no regex hackery...
From the Lean3 vscode extension readme:

Fill in {! !} holes (also _ holes in Lean 3.16.0c and later) with the code actions menu (ctrl+.)
Tactic suggestions (tactics which suggest edits with a "Try this:" message) can be applied either with a keyboard shortcut (alt+v), by clicking on the info view message, or via code actions (ctrl+.)

the syntax is a bit weird though... (from idris) can we do it without magic syntax?
@lovettchris lovettchris self-assigned this Jan 13, 2022
@lovettchris lovettchris changed the title Code actions, to "try this" suggestions to replace Code actions, to "fill holes" with suggestions from Lean Language Server Jan 26, 2022
@GetContented
Copy link

Will this also allow us to get agda/idris style case splitting?

@lovettchris
Copy link
Contributor Author

See also leanprover/lean4#1223

@leodemoura leodemoura added the nice to have It would be great to have or fix, but it is not essential. label Jun 28, 2022
@leodemoura
Copy link
Member

We should do it after the first official release, and the new Widget extensions have been deployed.

@EdAyers EdAyers mentioned this issue Aug 17, 2022
Open
5 tasks
@Vtec234
Copy link
Member

Vtec234 commented Jun 7, 2023

These are now in leanprover-community/batteries#132.

@Vtec234 Vtec234 closed this as completed Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lovettchris lovettchris

Labels
nice to have It would be great to have or fix, but it is not essential.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@leodemoura @GetContented @Vtec234 @lovettchris