feat: tactic code actions framework #132
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a code action provider which uses the
@[tactic_code_action]
attribute to register code actions specifically on tactics and tactic sequences. The main purpose is to allow for having many code actions which all use the same syntax / info tree traversal setup.This implementation is a bit sophisticated, because it wants to avoid calling tactic code actions for multiple overlapping tactics. It selects the innermost applicable tactic, or the space between tactics for tacticSeq code actions.
So far there are not many actual code actions implemented. A basic tactic code action added here is the
Remove tactics after 'no goals'
code action which removes a tactic which is called on no goals, and anything after it.