Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tactic code actions framework #132

Merged
merged 9 commits into from
May 16, 2023
Merged

feat: tactic code actions framework #132

merged 9 commits into from
May 16, 2023

Conversation

digama0
Copy link
Member

@digama0 digama0 commented May 9, 2023

This implements a code action provider which uses the @[tactic_code_action] attribute to register code actions specifically on tactics and tactic sequences. The main purpose is to allow for having many code actions which all use the same syntax / info tree traversal setup.

This implementation is a bit sophisticated, because it wants to avoid calling tactic code actions for multiple overlapping tactics. It selects the innermost applicable tactic, or the space between tactics for tacticSeq code actions.

So far there are not many actual code actions implemented. A basic tactic code action added here is the Remove tactics after 'no goals' code action which removes a tactic which is called on no goals, and anything after it.

@digama0 digama0 force-pushed the tactic_code_actions branch from b2d5f50 to d3a3ec8 Compare May 9, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant