metadata type changed to bytes #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justheuristic
approved these changes
Jun 28, 2022
Codecov Report
@@ Coverage Diff @@
## master #491 +/- ##
==========================================
+ Coverage 85.44% 85.68% +0.24%
==========================================
Files 80 80
Lines 7812 7812
==========================================
+ Hits 6675 6694 +19
+ Misses 1137 1118 -19
|
|
@GreenFatGuy please check the compatibility fix. If it looks alright, feel free to merge (with optionally updated description) |
mryab
pushed a commit
that referenced
this pull request
Sep 13, 2022
Type of metadata field in Expert Request/Response changed to more native type `bytes` and some compatibility fixes are done to the tests to fit different `torch` versions (cherry picked from commit fe7a4ef)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change type of ExpertRequest/Response metadata to bytes because bytes are native output/input for serializers (for example
MSGPackSerializerused in hivemind)