Remove stale PeerIDs in hivemind-dht's routing table #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justheuristic
approved these changes
Nov 29, 2022
Co-authored-by: justheuristic <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #525 +/- ##
==========================================
+ Coverage 75.97% 75.99% +0.01%
==========================================
Files 81 81
Lines 7960 7962 +2
==========================================
+ Hits 6048 6051 +3
+ Misses 1912 1911 -1
|
mryab
pushed a commit
that referenced
this pull request
Nov 29, 2022
Before this PR, hivemind-dht-based initial peers collected lots of stale PeerIDs and other peers could not actually make DHT queries anymore. (cherry picked from commit be88b42)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, hivemind-dht-based initial peers collected lots of stale PeerIDs and other peers could not actually make DHT queries anymore.