Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DecentralizedAverager resistant to KeyboardInterrupt #530

Merged

Conversation

ikmckenz
Copy link
Contributor

@ikmckenz ikmckenz commented Dec 8, 2022

Very simple one line change, using the same approach as taken by the DHT. Resolves #382.

Tested working:

Screenshot from 2022-12-07 19-04-07

@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Merging #530 (c8e915c) into master (be88b42) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #530      +/-   ##
==========================================
+ Coverage   76.04%   76.06%   +0.01%     
==========================================
  Files          81       81              
  Lines        7962     7964       +2     
==========================================
+ Hits         6055     6058       +3     
+ Misses       1907     1906       -1     
Impacted Files Coverage Δ
hivemind/averaging/averager.py 47.85% <100.00%> (+0.24%) ⬆️
hivemind/dht/routing.py 94.11% <0.00%> (+0.58%) ⬆️

Copy link
Member

@justheuristic justheuristic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! That should make averager more convenient to use interactively.

@justheuristic justheuristic merged commit 19aa966 into learning-at-home:master Dec 8, 2022
mryab pushed a commit that referenced this pull request Jan 7, 2023
@ikmckenz ikmckenz deleted the averager-keyboard-resistant branch March 8, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Make DecentralizedAverager resistant to KeyboardInterrupt
2 participants