Support circuit relay v2, add tests #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Vahe1994
commented
Dec 22, 2022
•
Vahe1994
commented
- switched to p2pd version 0.3.16
- added support for Circuit Relay V2 in all hivemind protocols
- added an option no_listen=False for testing purposes (hivemind.p2p.p2p_daemon)
- added a test that checks if a peer can connect to another peer through circuit relay
justheuristic
changed the title
|
related: #536 |
Codecov Report
@@ Coverage Diff @@
## master #537 +/- ##
==========================================
- Coverage 76.00% 75.99% -0.01%
==========================================
Files 81 81
Lines 7964 7966 +2
==========================================
+ Hits 6053 6054 +1
- Misses 1911 1912 +1
|
|
note: failed docker push is not an urgent issue and can be resolved when we finalize this PR |
2. (Partly)Wrote test for automatic checking relays(need fix, under NAT can't perform testing)
justheuristic
approved these changes
Dec 29, 2022
justheuristic
changed the title
tests/test_relays.py
Outdated
|
|
||
| dht_third_peer = hivemind.DHT( | ||
| initial_peers=initial_peers, | ||
| host_maddrs=["/ip4/0.0.0.0/tcp/0"], |
There was a problem hiding this comment.
Suggested change
| host_maddrs=["/ip4/0.0.0.0/tcp/0"], | |
| host_maddrs=[], |
no_listen means no host_maddrs
2. Added loop for relays 3. Changed relays parameters
2. Fixed autorelay test sleep and correct order of dht peers and added more sleep time beetween peers
Vahe1994
changed the title
mryab
pushed a commit
that referenced
this pull request
Jan 7, 2023
- switched to p2pd version 0.3.16 - added support for Circuit Relay V2 in all hivemind protocols - added an option no_listen=False for testing purposes (hivemind.p2p.p2p_daemon) - added a test that checks if a peer can connect to another peer through circuit relay Co-authored-by: justheuristic <[email protected]> (cherry picked from commit 9d89a7b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.