Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a broken URL in contributing.md #538

Merged
merged 9 commits into from
Dec 26, 2022

Conversation

Vahe1994
Copy link
Collaborator

Fixed the link to contributing.md in github

Fixed the link to contributing.md in github
@Vahe1994 Vahe1994 marked this pull request as ready for review December 26, 2022 17:17
Copy link
Member

@justheuristic justheuristic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but gotta fix the docker build, working on it now

@codecov
Copy link

codecov bot commented Dec 26, 2022

Codecov Report

Merging #538 (7c8ec69) into master (e98c24a) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #538      +/-   ##
==========================================
- Coverage   76.01%   76.00%   -0.02%     
==========================================
  Files          81       81              
  Lines        7964     7964              
==========================================
- Hits         6054     6053       -1     
- Misses       1910     1911       +1     
Impacted Files Coverage Δ
hivemind/dht/node.py 90.99% <0.00%> (-1.19%) ⬇️
hivemind/moe/server/server.py 44.26% <0.00%> (+0.54%) ⬆️
hivemind/dht/protocol.py 93.15% <0.00%> (+0.91%) ⬆️
hivemind/moe/server/connection_handler.py 47.91% <0.00%> (+1.04%) ⬆️

@Vahe1994 Vahe1994 changed the title Update contributing.md Fix a broken URL in contributing.md Dec 26, 2022
@Vahe1994 Vahe1994 merged commit e584bb5 into master Dec 26, 2022
@Vahe1994 Vahe1994 deleted the Vahe1994-patch-link-contributing branch December 26, 2022 20:15
mryab pushed a commit that referenced this pull request Jan 7, 2023
Fixed the url in contributing.md with working one.

Co-authored-by: justheuristic <[email protected]>
(cherry picked from commit e584bb5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants