Require torch<2.0 until 2.0 is supported, add Python 3.10 to CI #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #558 +/- ##
==========================================
- Coverage 76.01% 75.98% -0.03%
==========================================
Files 81 81
Lines 7995 7995
==========================================
- Hits 6077 6075 -2
- Misses 1918 1920 +2 |
Merged
borzunov
commented
Mar 28, 2023
| @@ -17,7 +17,7 @@ jobs: | |||
| with: | |||
| python-version: 3.9 | |||
| - name: Cache dependencies | |||
| uses: actions/cache@v2 | |||
| uses: actions/cache@v3 | |||
borzunov
commented
Mar 28, 2023
| @@ -20,7 +20,7 @@ class NodeKiller: | |||
| """Auxiliary class that kills dht nodes over a pre-defined schedule""" | |||
|
|
|||
| def __init__(self, shutdown_peers: list, shutdown_timestamps: list): | |||
| self.shutdown_peers = set(shutdown_peers) | |||
| self.shutdown_peers = shutdown_peers | |||
There was a problem hiding this comment.
random.choice() doesn't support sets in 3.10, let's keep it a list.
borzunov
changed the title
borzunov
changed the title
borzunov
commented
Mar 28, 2023
| @@ -5,7 +5,6 @@ pytest-cov | |||
| coverage==6.0.2 # see https://github.com/pytest-dev/pytest-cov/issues/520 | |||
| tqdm | |||
| scikit-learn | |||
| torchvision | |||
There was a problem hiding this comment.
Seems like an excess dependency.
If present, it forces to upgrade torch to 2.0.0 during pip install -r requirements-dev.txt, which breaks installation from source (build_and_test_p2pd in CI).
mryab
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyTorch 2.0 is not supported yet, it's support will be added in #559 (there are multiple issues to resolve). Until then, we need to require
torch<2.0.0(otherwise 2.0.0 is installed, so CI doesn't work right now).This PR also adds Python 3.10 to the CI.