Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

icon button accepts both a tooltip and an aria label #168

Closed
indirectlylit opened this issue Feb 20, 2021 · 2 comments
Closed

icon button accepts both a tooltip and an aria label #168

indirectlylit opened this issue Feb 20, 2021 · 2 comments
Assignees
@AlexVelezLl
Labels
category: library Shared code library Component: KIconButton TODO: needs decisions Further discussion and planning necessary type: proposal New feature or request
Milestone
KDS Priority Triage

Comments

@indirectlylit
Copy link
Contributor

indirectlylit commented Feb 20, 2021 •
edited
Loading

The tooltip and ariaLabel props should be consolidated into just text (for consistency with other button components) and made required
@indirectlylit indirectlylit added category: library Shared code library type: proposal New feature or request labels Feb 20, 2021
indirectlylit added a commit to indirectlylit/kolibri-design-system that referenced this issue Feb 20, 2021
@indirectlylit
make text props required for buttons
c44c3ef 
ref learningequality#168
indirectlylit added a commit to indirectlylit/kolibri-design-system that referenced this issue Feb 20, 2021
@indirectlylit
make text props required for buttons
d205313 
ref learningequality#168
indirectlylit added a commit to indirectlylit/kolibri-design-system that referenced this issue Feb 23, 2021
@indirectlylit
make text props required for buttons
8c1a061 
ref learningequality#168
indirectlylit added a commit to indirectlylit/kolibri-design-system that referenced this issue Feb 27, 2021
@indirectlylit
make text props required for buttons
a50529d 
ref learningequality#168
@indirectlylit indirectlylit mentioned this issue Feb 27, 2021
Closed
This was referenced Apr 12, 2021
Closed
Merged
@marcellamaki marcellamaki mentioned this issue Sep 7, 2021
Closed
@nucleogenesis
Copy link
Member

Issue needs decisions around the proper acceptance criteria - ensuring that whatever changes are made to this effect are a11y focused

@nucleogenesis nucleogenesis added the TODO: needs decisions Further discussion and planning necessary label Sep 17, 2024
@nucleogenesis nucleogenesis added this to the KDS Priority Triage milestone Sep 17, 2024
@AlexVelezLl
Copy link
Member

I talked to Radinna and she suggeted not to have a fixed relation between a tooltip and an ariaLabel for cases where we need to announce something more specific as ariaLabel. But we agreed in that we can have the tooltip prop as fallback for the aria label when the prop ariaLabel is missing: #793.

@AlexVelezLl AlexVelezLl closed this as not planned Won't fix, can't repro, duplicate, stale Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexVelezLl AlexVelezLl

Labels
category: library Shared code library Component: KIconButton TODO: needs decisions Further discussion and planning necessary type: proposal New feature or request
Projects
None yet
Milestone
KDS Priority Triage
Development

No branches or pull requests
4 participants
@indirectlylit @nucleogenesis @MisRob @AlexVelezLl