Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add anchor links to individual glossary terms #174

Merged
merged 1 commit into from
Feb 23, 2021

Conversation

marcellamaki
Copy link
Member


name: Pull Request
about: Create a pull request
title: "Add anchor tags to glossary"
labels: 'docs, Q1 Milestone'
assignees: ''


Description

Adds anchor links on the glossary page to each individual term

Issue Addressed

Fixes #146

Before/After Screenshots

BEFORE
Screen Shot 2021-02-22 at 6 33 26 PM

AFTER
Screen Shot 2021-02-22 at 6 32 42 PM

(Optional) Implementation Notes

At a high level, how did you implement this?

Based on the Icons page, I similarly created a method to dynamically add anchor links based on the term, and used the <DocsAnchorTarget/> component to handle the styling.

Checklist for the Reviewer

  • Is the code clean and well-commented?
  • Do the anchor links work as expected

Copy link
Contributor

@indirectlylit indirectlylit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@indirectlylit indirectlylit merged commit 4a2ae39 into learningequality:v0.2.x Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

glossary terms do not have anchor links
2 participants