Exercise icon flipped in rtl #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sairina
suggested changes
Feb 16, 2022
| @@ -0,0 +1,5 @@ | |||
| describe("KButton", () => { | |||
There was a problem hiding this comment.
Is this part of this issue?
There was a problem hiding this comment.
🤦♂️ no will remove and push again later on - thanks for catching that!
lib/KIcon/iconDefinitions.js
Outdated
| exercise: { icon: require('./precompiled-icons/material-icons/assignment/baseline.vue').default }, | ||
| exercise: { | ||
| icon: require('./precompiled-icons/material-icons/assignment/baseline.vue').default, | ||
| rtlFlip: true |
There was a problem hiding this comment.
Ahh - so now, if this is true, and the language is also rtl, then in the KIcon file itself, the class of 'rtl-flip-icon' will also be true, and the icon will be flipped?
nucleogenesis
force-pushed
the
flip-exercise-icon
branch
from
79a6c4b to
a5991a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the configuration file so that the Exercise icon flips when in RTL.
Reviewer Guidance
Fixes #301