Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addresses issue #694 #853

Closed
wants to merge 3 commits into from
Closed

Conversation

shruti862
Copy link
Contributor

Description

I added Overview and Usage section on KTooltip documentation page

Issue addressed

Fixes issue #694

@MisRob
Copy link
Member

MisRob commented Dec 9, 2024

Thank you @shruti862, I will review. Some files leaked here from your other pull request. Would you please make sure there's only ktooltip file changes in this pull request?

@MisRob MisRob self-requested a review December 9, 2024 09:00
@MisRob MisRob self-assigned this Dec 9, 2024
@MisRob MisRob added the TODO: needs review Waiting for review label Dec 9, 2024
@MisRob
Copy link
Member

MisRob commented Dec 9, 2024

Also @shruti862, you need to run yarn lint-fix to fix the lint check failure.

And on all your pull requests, I'd ask you to keep the changelog section in the pull request description. You can even try to fill it in, even though it's not strictly required. Just don't remove it :) We need it because it gets automatically pasted to our changelog after merging pull requests.

@shruti862
Copy link
Contributor Author

@MisRob thanks for the info.

@shruti862 shruti862 closed this Dec 9, 2024
@shruti862 shruti862 mentioned this pull request Dec 9, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants