Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert inadvertent changes to KLogo path during linting. #868

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Revert inadvertent changes to KLogo path during linting. #868

merged 1 commit into from
Dec 11, 2024

Conversation

rtibbles
Copy link
Member

Description

Before/after screenshots

Before:
Screenshot from 2024-12-10 18-10-24

After:
image

Changelog

  • Description: Revert regression in KLogo display
  • Products impact: bugfix
  • Addresses: -
  • Components: KLogo
  • Breaking: no
  • Impacts a11y: no
  • Guidance: -

Steps to test

  1. Look at the docs
  2. Check the logo
  3. Confirm the bird is not flipping its beak!

Comments

@rtibbles
Revert inadvertent changes to KLogo path during linting.
caf035b 
Choose to ignore linting max length instead.
AlexVelezLl
AlexVelezLl approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@AlexVelezLl AlexVelezLl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rtibbles!

@AlexVelezLl AlexVelezLl merged commit fdfb6ed into learningequality:develop Dec 11, 2024
9 of 10 checks passed
learning-equality-bot bot pushed a commit that referenced this pull request Dec 11, 2024
@github-actions
Update CHANGELOG.md for PR #868
6c6b208
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexVelezLl AlexVelezLl AlexVelezLl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rtibbles @AlexVelezLl