Fix bug not beign able to update resources

learningequality · May 29, 2024 · 7bb7603 · 7bb7603
1 parent 81f3194
commit 7bb7603
Showing 1 changed file with 10 additions and 12 deletions.
diff --git a/kolibri/plugins/coach/assets/src/composables/useQuizCreation.js b/kolibri/plugins/coach/assets/src/composables/useQuizCreation.js
@@ -117,19 +117,17 @@ export default function useQuizCreation() {
             },
             []
           );
-          if (removedResourceQuestionIds.length === 0) {
-            // If no resources were removed, we don't need to update the questions
-            return;
+          if (removedResourceQuestionIds.length !== 0) {
+            const questionsToKeep = originalQuestions.filter(
+              q => !removedResourceQuestionIds.includes(q.id)
+            );
+            const numReplacementsNeeded =
+              (question_count || originalQuestionCount) - questionsToKeep.length;
+            updates.questions = [
+              ...questionsToKeep,
+              ...selectRandomQuestionsFromResources(numReplacementsNeeded, resource_pool),
+            ];
           }
-          const questionsToKeep = originalQuestions.filter(
-            q => !removedResourceQuestionIds.includes(q.id)
-          );
-          const numReplacementsNeeded =
-            (question_count || originalQuestionCount) - questionsToKeep.length;
-          updates.questions = [
-            ...questionsToKeep,
-            ...selectRandomQuestionsFromResources(numReplacementsNeeded, resource_pool),
-          ];
         }
       }
     } else if (question_count !== originalQuestionCount) {