-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"NaN B" displayed in coach when toggling lesson visibility #10797
Labels
Milestone
Comments
I'll dive into this within the scope of #10729 |
I thought I'd caught all these in this PR: #10720 - seems like we need to make sure that the lesson save action should only resolve once the size fetch has also resolved. |
MisRob
added a commit
to MisRob/kolibri
that referenced
this issue
Aug 31, 2023
so that they can be commited together with their sizes. Fixes learningequality#10797
MisRob
added a commit
to MisRob/kolibri
that referenced
this issue
Sep 1, 2023
so that they can be commited together with their sizes. Fixes learningequality#10797
MisRob
added a commit
to MisRob/kolibri
that referenced
this issue
Sep 2, 2023
so that they can be commited together with their sizes. Fixes learningequality#10797
MisRob
added a commit
to MisRob/kolibri
that referenced
this issue
Sep 3, 2023
so that they can be commited together with their sizes. Fixes learningequality#10797
MisRob
added a commit
to MisRob/kolibri
that referenced
this issue
Sep 3, 2023
so that they can be commited together with their sizes. Fixes learningequality#10797
MisRob
added a commit
to MisRob/kolibri
that referenced
this issue
Sep 3, 2023
so that they can be commited together with their sizes. Fixes learningequality#10797
MisRob
added a commit
to MisRob/kolibri
that referenced
this issue
Sep 7, 2023
so that they can be commited together with their sizes. Fixes learningequality#10797
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Observed behavior
in
Coach
, there is sometimes noticeable shaky behavior when toggling lesson visibility in theReports
&Plan
tabs. if you throttle your network to "Slow 3G," it becomes clear this is related toNaN B
being temporarily displayed during some transitions in lesson visibility.Screen recording
NaNNaNNaN.mov
Expected behavior
it would be preferable for UI to display
0B
or-
overNaN B
, which looks buggy and does not convey any useful information to the user. notably, the value of "Total size of lessons visible to learners" is0
while size in the table is displayed asNaN B
- maybe the implementation of the former could be smoothly adapted for the latter.it would be ideal for the table columns to have fixed widths in this specific case, as the current responsiveness of the column widths leads to a jittery UI when
NaN B
flashes into view (though this may not mesh with other usages of the table component)User-facing consequences
Steps to reproduce
in a facility that contains at least 1 class, visit that class's
Report
&Plan
tabs and toggle "Visible to learners" several times (they behavior does not occur on every on/off toggle)The text was updated successfully, but these errors were encountered: