Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"NaN B" displayed in coach when toggling lesson visibility #10797

Closed
thanksameeelian opened this issue Jun 7, 2023 · 2 comments · Fixed by #11201
Closed

"NaN B" displayed in coach when toggling lesson visibility #10797

thanksameeelian opened this issue Jun 7, 2023 · 2 comments · Fixed by #11201
Assignees
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) bug Behavior is wrong or broken

Comments

@thanksameeelian
Copy link
Contributor

Observed behavior

in Coach, there is sometimes noticeable shaky behavior when toggling lesson visibility in the Reports & Plan tabs. if you throttle your network to "Slow 3G," it becomes clear this is related to NaN B being temporarily displayed during some transitions in lesson visibility.

Screen recording

NaNNaNNaN.mov

Expected behavior

it would be preferable for UI to display 0B or - over NaN B, which looks buggy and does not convey any useful information to the user. notably, the value of "Total size of lessons visible to learners" is 0 while size in the table is displayed as NaN B - maybe the implementation of the former could be smoothly adapted for the latter.

it would be ideal for the table columns to have fixed widths in this specific case, as the current responsiveness of the column widths leads to a jittery UI when NaN B flashes into view (though this may not mesh with other usages of the table component)

User-facing consequences

it's weird man

Steps to reproduce

in a facility that contains at least 1 class, visit that class's Report & Plan tabs and toggle "Visible to learners" several times (they behavior does not occur on every on/off toggle)

@thanksameeelian thanksameeelian added APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) bug Behavior is wrong or broken labels Jun 7, 2023
@nucleogenesis nucleogenesis self-assigned this Jun 7, 2023
@nucleogenesis
Copy link
Member

I'll dive into this within the scope of #10729

@rtibbles
Copy link
Member

rtibbles commented Jun 8, 2023

I thought I'd caught all these in this PR: #10720 - seems like we need to make sure that the lesson save action should only resolve once the size fetch has also resolved.

@MisRob MisRob assigned MisRob and unassigned nucleogenesis Aug 30, 2023
MisRob added a commit to MisRob/kolibri that referenced this issue Aug 31, 2023
so that they can be commited together with their sizes.

Fixes learningequality#10797
MisRob added a commit to MisRob/kolibri that referenced this issue Sep 1, 2023
so that they can be commited together with their sizes.

Fixes learningequality#10797
MisRob added a commit to MisRob/kolibri that referenced this issue Sep 2, 2023
so that they can be commited together with their sizes.

Fixes learningequality#10797
MisRob added a commit to MisRob/kolibri that referenced this issue Sep 3, 2023
so that they can be commited together with their sizes.

Fixes learningequality#10797
MisRob added a commit to MisRob/kolibri that referenced this issue Sep 3, 2023
so that they can be commited together with their sizes.

Fixes learningequality#10797
MisRob added a commit to MisRob/kolibri that referenced this issue Sep 3, 2023
so that they can be commited together with their sizes.

Fixes learningequality#10797
MisRob added a commit to MisRob/kolibri that referenced this issue Sep 7, 2023
so that they can be commited together with their sizes.

Fixes learningequality#10797
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) bug Behavior is wrong or broken
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants