Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Select All" checkbox in MyDownloadsPage can be checked with no selectable items #11026

Closed
marcellamaki opened this issue Jul 27, 2023 · 1 comment · Fixed by #11092
Closed
Assignees
Labels

Comments

@marcellamaki
Copy link
Member

Observed behavior

Reported by @nucleogenesis during the beta0 bug bash

when all items in the table are disabled, the “Select all” checkbox is not disabled, so I can still manage to select everything using that checkbox — noting it, but if the rows weren’t disabled, then this is behaving as intended beside the fact that clicking “Remove Selected” does nothing

https://www.notion.so/learningequality/Cannot-remove-item-I-selected-to-download-on-My-Downloads-page-7e87f388f8a74df4a6263f0bfd6f884a?pvs=4

Errors and logs

Screenshot 2023-07-27 at 4 28 17 PM

Expected behavior

"Select all" should only be enabled if one or more items are selectable

User-facing consequences

Confusion, mis-selecting items

Steps to reproduce

Initiate a download and navigate to the "My Downloads" page

Context

beta0

@nucleogenesis
Copy link
Member

Fair chance that the issue causing this is the same as #11029

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants