-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MyDownloads bug fixes #11092
MyDownloads bug fixes #11092
Conversation
05e76a4
to
1270314
Compare
Build Artifacts
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some things that could be cleaned up, at least one thing that looks incorrect to me.
kolibri/plugins/learn/assets/src/my_downloads/views/DownloadsList/index.vue
Outdated
Show resolved
Hide resolved
kolibri/plugins/learn/assets/src/my_downloads/views/DownloadsList/index.vue
Show resolved
Hide resolved
kolibri/plugins/learn/assets/src/my_downloads/views/DownloadsList/index.vue
Outdated
Show resolved
Hide resolved
kolibri/plugins/learn/assets/src/my_downloads/views/DownloadsList/index.vue
Show resolved
Hide resolved
kolibri/plugins/learn/assets/src/my_downloads/views/MyDownloads.vue
Outdated
Show resolved
Hide resolved
1270314
to
6a2447d
Compare
3d71b05
to
7e6354d
Compare
7e6354d
to
2f0dd63
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Main feedback addressed - additional cleanup and tweaks can happen in follow up.
Test failure is due to a flaky test from another PR. Merging, will resolve elsewhere. |
Summary
This PR generally:
Cleans up/improves reactivity on the frontend
Fixes broken remove download functionality
References
Fixes #11026
Fixes #11044
my-downloads-page.mp4
Reviewer guidance
there will be a follow up PR on Monday that manages:
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)