Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace KResponsiveWindow mixin by useKResponsiveWindow composable - Device plugin #11322

Closed
Tracked by #11321
MisRob opened this issue Sep 29, 2023 · 6 comments
Closed
Tracked by #11321
Assignees
Labels
DEV: frontend good first issue Self-contained, straightforward, low-complexity help wanted Open source contributors welcome P2 - normal Priority: Nice to have

Comments

@MisRob
Copy link
Member

MisRob commented Sep 29, 2023

This is one of the issues whose common goal is to gradually replace KResponsiveWindow mixin by useKResponsiveWindow composable.

First, see #11321 for detailed instructions and acceptance criteria common to all issues.

Then, replace KResponsiveWindow mixin by useKResponsiveWindow composable in all .vue files of the Device plugin (/kolibri/plugins/device)

@thesujai
Copy link
Contributor

thesujai commented Oct 2, 2023

@MisRob Please, assign this to me

@MisRob
Copy link
Member Author

MisRob commented Oct 2, 2023

Hi @thesujai, thank you for volunteering. I'm assigning this one to you.

I can also see you volunteered for other issues from this group. Kindly request, please ask for an assignment of a reasonable amount of issues. Each one of these will take some time as you will need to find places to test etc. As soon as you complete your assigned issues, you're welcome to ask for more. If you decide not to work on some of them, but rather worked on something else, please let us know and we can re-assign you. Thank you.

@MisRob
Copy link
Member Author

MisRob commented Oct 2, 2023

@thesujai Note that even though we will review your pull request, it might take some time to merge it because we have some important fixes in progress for useKResponsiveWindow (learningequality/kolibri-design-system#453) that we might need to finish at first before we use the composable more widely. It's not a blocker for working on this though.

@thesujai
Copy link
Contributor

thesujai commented Oct 2, 2023

@MisRob Thank you for the assignment.
I understand and will work on this #11322 and #11333, leaving rest for other community contributers.

@MisRob
Copy link
Member Author

MisRob commented Oct 2, 2023

You're more than welcome to volunteer for other issues as well @thesujai, just not all at once. Thank you for your understanding.

@MisRob
Copy link
Member Author

MisRob commented Oct 26, 2023

Closed by #11349

@MisRob MisRob closed this as completed Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: frontend good first issue Self-contained, straightforward, low-complexity help wanted Open source contributors welcome P2 - normal Priority: Nice to have
Projects
None yet
Development

No branches or pull requests

2 participants