-
Notifications
You must be signed in to change notification settings - Fork 744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate quizzes to updated resource selection #13043
base: develop
Are you sure you want to change the base?
Migrate quizzes to updated resource selection #13043
Conversation
@@ -0,0 +1,431 @@ | |||
<template> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even though github shows this as a new file, I managed to keep the blame, as this was renamed and refactored from https://github.com/learningequality/kolibri/pull/13043/files#diff-de1998b52a97bdcd29e801e6fee5e43980b32478bf3afda44537e61aba2b47a8
Build Artifacts
|
@pcenov (cc @radinamatic) this should also be ready for manual QA - Alex has left a few notes above. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like the injection w/ the bookmarks, channels, etc objects w/ the annotator function and such - a very clean way to pass around and handle that logic <3
I left a few comments and read through the code and in general, things are looking great.
I didn't get a chance to manage my resources due to the error I noted below - ping me if you cannot replicate it or when you're able to resolve it - I look forward to playing with this PR 😃
selectAllRules: { | ||
type: Array, | ||
required: false, | ||
default: () => [], | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears to expect an array of functions, might be good to add a validator to that effect. Could use lodash's isFunction on each item given to make it simple
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also it might be good to note in a comment here that it specifically expects a set of predicate functions that should return bools
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Just did it! :)
}, | ||
}, | ||
beforeRouteEnter(to, from, next) { | ||
next(vm => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This prevents me from adding any contents as everything beneath the "[] Choose questions manually" string is blank
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm thats weird, I am not getting it, Im not using a KRadioButton anywhere in that page 🤔, and thats a warning of a KRadioButton validator, it shouldnt prevent us from seeing the rendered component 🤔.
Are you seeing any other errors in the console? Could you send a screencast/screenshot of what are you seeing in the side panel?
Hi @AlexVelezLl - I was able to identify the following issues:
1.error.when.adding.a.new.section.mp4
back.arrow.mp4 |
5d416a4
to
cf3cb51
Compare
Thanks @pcenov! I have just pushed a fix for the navigation from the section settings to the resource selection side panel! For number two, this is actually an issue with our Design System, I think this issue is related learningequality/kolibri-design-system#242 cc: @marcellamaki @jtamiace. |
@pcenov the reason why there is no back button on the 'Add questions to' page is to avoid any confusion in how it should behave in relation to the channel/folder breadcrumb (will this back button take me "up" a folder level? Behave as a browser back? Leave the question adding process entirely?). But I do see how this layout is still confusing from your description. One small change that comes to mind is changing the button label from "Settings" to "Questions" to create more specificity. But I'm curious if there is another behavior you would expect instead? |
Thanks @AlexVelezLl - I confirm that the navigation from the section settings is working correctly now. Hi @jtamiace - I think that if we decide to add a back arrow it should behave exactly as the browser's back button, I don't see any harm in doing so (though there could be some edge cases). The "Settings" button could also be renamed to "Questions settings" if it's not too long. On that note, are we supporting viewing this page in mobile phones, because the buttons don't look positioned correctly in resolution which is less than 600px: |
Hi @pcenov! I have made the button icon a little bigger. The alignment problem will be tracked with this issue learningequality/kolibri-design-system#931. For the layout in small screens, for now I have at least aligned them to the right |
Thanks @AlexVelezLl - I confirm that the buttons are aligned to the right now. |
Summary
common
to use the same components for lessons and quizzes.Screencast
Compartir.pantalla.-.2025-01-30.11_54_11.mp4
References
Closes #12994.
Reviewer guidance