Migrate quizzes to updated resource selection #13043
Conversation
github-actions
bot
added
APP: Coach
| @@ -0,0 +1,431 @@ | |||
| <template> | |||
There was a problem hiding this comment.
Even though github shows this as a new file, I managed to keep the blame, as this was renamed and refactored from https://github.com/learningequality/kolibri/pull/13043/files#diff-de1998b52a97bdcd29e801e6fee5e43980b32478bf3afda44537e61aba2b47a8
Build Artifacts
|
|
@pcenov (cc @radinamatic) this should also be ready for manual QA - Alex has left a few notes above. Thank you! |
There was a problem hiding this comment.
I really like the injection w/ the bookmarks, channels, etc objects w/ the annotator function and such - a very clean way to pass around and handle that logic <3
I left a few comments and read through the code and in general, things are looking great.
I didn't get a chance to manage my resources due to the error I noted below - ping me if you cannot replicate it or when you're able to resolve it - I look forward to playing with this PR 😃
| selectAllRules: { | ||
| type: Array, | ||
| required: false, | ||
| default: () => [], | ||
| }, |
There was a problem hiding this comment.
This appears to expect an array of functions, might be good to add a validator to that effect. Could use lodash's isFunction on each item given to make it simple
There was a problem hiding this comment.
Also it might be good to note in a comment here that it specifically expects a set of predicate functions that should return bools
| }, | ||
| }, | ||
| beforeRouteEnter(to, from, next) { | ||
| next(vm => { |
There was a problem hiding this comment.
I'm getting this error, the initial stack trace points to here
There was a problem hiding this comment.
This prevents me from adding any contents as everything beneath the "[] Choose questions manually" string is blank
Summary
commonto use the same components for lessons and quizzes.Screencast
Compartir.pantalla.-.2025-01-30.11_54_11.mp4
References
Closes #12994.
Reviewer guidance