-
Notifications
You must be signed in to change notification settings - Fork 776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set Vue to 2.5.17 and use watcher-based optimizations on responsive window mixin #4075
Comments
According to the releases page, 2.5.17:
Looks like they had an emergency security fix, and those beta changes will come in 2.5.18? |
also, by committing 34edbc4 we are no longer testing the beta |
A little confused by this issue @indirectlylit, as 2.5.18 still hasn't been released? |
Darn. I'd hoped it would have been released by now. I upgraded because we need the performance improvements in vuejs/vue#7824 Unfortunately that change caused a regression: vuejs/vue#8446 I'll need to make a performance update to work around this |
@devon Is there a specific component that was causing issues? |
Yes it was an optimization in the responsive window mixin, where the computed props were being re-calculated constantly during resizes rather than just at breakpoint thresholds. I think we'll basically need to revert this commit: 355acf3 |
In #4065 we're setting vue to a beta version for testing. It's very important that we upgrade vue to 2.5.17 final before release 0.11.0
check version on npm page
The text was updated successfully, but these errors were encountered: