Add download button to BrowseResourceMetadata #11055
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
References
Fixes #11027
Reviewer guidance
Does the download button display properly? Does it not display for remote browsing?
For local:
![Screenshot from 2023-08-02 14-34-47](https://private-user-images.githubusercontent.com/1680573/257950817-75f4a009-4d02-41f0-adda-e98a2f8140c3.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzNTQzMDcsIm5iZiI6MTczOTM1NDAwNywicGF0aCI6Ii8xNjgwNTczLzI1Nzk1MDgxNy03NWY0YTAwOS00ZDAyLTQxZjAtYWRkYS1lOThhMmY4MTQwYzMucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTJUMDk1MzI3WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MDNmNmIzODU2ZjZjOTkyNzRlMTNmYTAyYzQwNzY1Y2E5YmY5MGNlOWY3NTNiNjI4ZGEyOThhMTIyYTExZGYzOSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.vab3BSXcSC7ScmkBGEVRp970zRKjzLwIHAT2naL6VQs)
For remote:
![Screenshot from 2023-08-02 14-35-52](https://private-user-images.githubusercontent.com/1680573/257950837-8faa3d91-0a72-486e-9ceb-d244090e9ec7.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzNTQzMDcsIm5iZiI6MTczOTM1NDAwNywicGF0aCI6Ii8xNjgwNTczLzI1Nzk1MDgzNy04ZmFhM2Q5MS0wYTcyLTQ4NmUtOWNlYi1kMjQ0MDkwZTllYzcucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTJUMDk1MzI3WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YmZjOTNlZTgzZTcyNmZkOTg3YjExYmI5YTQxYjYwZmFmNzBmZDVjZDI0MDYwZDYzNDRjYjU2ZjQwNmIyMDNhYSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.ReRvhCmZ70nxaKJ-5krurVP_KFNUjmcooEz6uukBVm8)
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)