Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add download button to BrowseResourceMetadata #11055

Merged
merged 3 commits into from
Aug 7, 2023

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Aug 2, 2023

Summary

  • Adds download button previously omitted from the browse resource metadata component
  • Cleans up an unnecessary and improperly passed prop value
  • Uses the HTML5 translation string for HTML5 app download for H5Ps

References

Fixes #11027

Reviewer guidance

Does the download button display properly? Does it not display for remote browsing?

For local:
Screenshot from 2023-08-02 14-34-47

For remote:
Screenshot from 2023-08-02 14-35-52


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added the TODO: needs review Waiting for review label Aug 2, 2023
@rtibbles rtibbles requested a review from marcellamaki August 2, 2023 21:56
@github-actions github-actions bot added APP: Learn Re: Learn App (content, quizzes, lessons, etc.) SIZE: small labels Aug 2, 2023
Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, once linting passes

@rtibbles
Copy link
Member Author

rtibbles commented Aug 7, 2023

Merging without the linting checks, as they are the flake8 failures that have been fixed on release-v0.16.x already.

@rtibbles rtibbles merged commit ce2ad03 into learningequality:release-v0.16.x Aug 7, 2023
@rtibbles rtibbles deleted the download_button branch August 7, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Learn Re: Learn App (content, quizzes, lessons, etc.) SIZE: small TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The "Info" Side Panel should have an updated "Download" button to now say "Save to device"
2 participants