Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout tweaks for Learn #11062

Merged
merged 2 commits into from
Aug 4, 2023

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Aug 4, 2023

Summary

  • Adds top spacing for the Home page
  • Uses KDS standard spacing for sections
  • Switches all TopicsPage displays to use only GridType 1 to avoid squashed cards on breakpoint 4

Reviewer guidance

Desktop:
Screenshot from 2023-08-04 14-25-27

Mobile:
Screenshot from 2023-08-04 14-26-48

Screenshot from 2023-08-04 14-53-56


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles requested a review from marcellamaki August 4, 2023 22:04
@rtibbles rtibbles added the TODO: needs review Waiting for review label Aug 4, 2023
@github-actions github-actions bot added APP: Learn Re: Learn App (content, quizzes, lessons, etc.) SIZE: small labels Aug 4, 2023
Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 all of the things that have been bothering me are fixed! thank you

@rtibbles rtibbles merged commit e09bf54 into learningequality:release-v0.16.x Aug 4, 2023
@rtibbles rtibbles deleted the layout_tweaks branch August 4, 2023 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Learn Re: Learn App (content, quizzes, lessons, etc.) SIZE: small TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants