Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links to issues in the contributing guidelines #11126

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

MisRob
Copy link
Member

@MisRob MisRob commented Aug 21, 2023

Summary

Links need to be updated from the obsolete "TAG: help wanted" and "TAG: good first issue" to "help wanted" and "good first issue" to correspond to the latest updates of the two GitHub labels (motivated by GitHub promotion of "good first issue" label in this literal format)

Reviewer guidance

Links should take you to correct search results

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@MisRob MisRob added the TODO: needs review Waiting for review label Aug 21, 2023
@MisRob MisRob requested review from bjester, rtibbles and vkWeb August 21, 2023 07:15
@rtibbles rtibbles merged commit 3d54cba into learningequality:release-v0.16.x Aug 21, 2023
@MisRob MisRob mentioned this pull request Aug 22, 2023
9 tasks
@MisRob MisRob deleted the docs-links-fix branch February 29, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants