-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigation issue in Channels #11272
Navigation issue in Channels #11272
Conversation
Signed-off-by: shivangrawat30 <[email protected]>
Build Artifacts
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ShivangRawat30, apologies but the expected result mentioned by me in #11187 is incorrect as it states: 'The user should be brought back to Device > Channels'
The actual expected result would be for the user to be brought back to the page they came from. So this should be corrected for all 3 available import options and the scenarios would be:
- Import from Kolibri Studio (online) > Select resources - clicking the Back arrow should bring the user back to 'Import from Kolibri Studio' modal
- Import from Local network or internet > Select resources - clicking the Back arrow should bring the user back to 'Import from 'Device' modal
- Import from Attached drive or memory card > Select resources - clicking the Back arrow should bring the user back to 'Import from 'Drive'' modal
Note that you can actually see the correct navigation flow if you use the browser's Back arrow. Let me know if you have any additional questions and many thanks for your efforts on fixing this!
![]() @pcenov I think the issue lies in the function |
cc @MisRob ⬆️ |
@ShivangRawat30 I will have a look at this in the next few days |
@ShivangRawat30 - yes, the function you are referencing should be imported into the component you have already updated, and then passed the drive id or the peer id if available to generate the back route. It may be a little cumbersome, but to be sure of the correct link, you can make the back computed prop completely explicit, checking against each of the cases - similarly to how the app bar title is generated: If it's Kolibri Studio, you can just call the function with no arguments to get the link, if it's peer import mode, you should pass the |
Hey @rtibbles I am having some trouble getting the ![]() ![]() |
That looks right - if you are in peerImport mode the If you are in localImport mode then These then need to be passed with the appropriate key to the options object for the So, either |
Signed-off-by: shivangrawat30 <[email protected]>
@rtibbles please have a look at the changes. 🙂 |
Signed-off-by: shivangrawat30 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like the right change to me! @pcenov could you confirm that the issue is fixed?
@ShivangRawat30 looks like there are two linting errors to take care of, removing the unused import of ContentWizardPages
and returning something from the backRoute
computed prop. I would suggest just returning availableChannelsPageLink()
after the if statements to ensure a value is always returned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manual QA passes! Thank you @ShivangRawat30!
Signed-off-by: shivangrawat30 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes make sense, manual QA checks out, we're ready to go! Thanks for the work on this, @ShivangRawat30 !
Summary
Solved the Navigation issue while importing from an attached drive/local network.
References
#11187
Reviewer guidance
…
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)