-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrates the OSUser associated with a facility user when migrating users. #11348
Migrates the OSUser associated with a facility user when migrating users. #11348
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How would I go about testing this? Code makes sense and sounds like a good idea anyway 😄
Build Artifacts
|
Probably the best way would be for me to rebase this on release, so you can test the 'on my own' setup wizard flow in the app context, then have you join a facility, and confirm that it still properly logs you in to your migrated user when accessing via the special URL. |
28454c2
to
9e1bdc5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes sense to me. Being inside the try
block I don't see any problem having this code. Worst case scenario would be not having the os_user
created.
The only problem is that I managed to encode a non-existent import... Thanks Copilot! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works as expected 👍🏻
Test failure is a known flaky test. |
Summary
get_os_user
capabilityReferences
…
Reviewer guidance
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)