-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace KResponseWindow with useKResponseWindow in User Profile plugin #11358
Replace KResponseWindow with useKResponseWindow in User Profile plugin #11358
Conversation
Build Artifacts
|
Hey @akolson @AllanOXDi, i am not sure in which page is the component |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look correct to me! Also, no regressions observed. cc @radinamatic @pcenov
@akolson Would it be possible to have more detailed reviewer guidance with verification steps for manual QA? Thank you! |
The only page that seems to be affected for manual QA here is checking that the Merge Facility workflow renders correctly (and without errors), especially on a small browser window. No need to test the full workflow, just pressing the 'join facility button' and ensuring nothing errors, and that it looks OK on a small browser window. |
Thanks @rtibbles. Yes that should be sufficient. |
@thesujai to Merge facility, follow the steps below;
|
@akolson I think @rtibbles's guidance was meant for QA team rather than @thesujai? By the way, @thesujai, if you ever needed to set up the other device, there's a guide for it https://kolibri-dev.readthedocs.io/en/develop/howtos/another_kolibri_instance.html. I think that here, it's fine to leave it for our QA or reviewers to test it out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues observed while manually testing, good to go!
Hi @MisRob. I think @thesujai requested for some visual testing guidance too; I guess he wanted to carry out some visual tests on his end.
|
@akolson Ah okay, thank you. I just wanted to clarify that even though it's welcome, it's not a blocker as QA folks will be too jumping in. |
There's a problem with tests though |
The issue is the |
Summary
For testing:
windowBreakpoint
is reached.KResponsiveWindow
anduseKResponsiveWindow
Page Affected:
KResponsiveWindow
and not used)…
References
Fixes #11333
…
Reviewer guidance
Would it be possible to add a
hacktoberfest-accepted
label in this PR?Here is the link: https://hacktoberfest.com/participation/#maintainers
Its fine if for some reasons you aren't able to do so:)
…
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)