Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced KResponsiveWindow to useKResponsiveWindow #11414

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

ShivangRawat30
Copy link
Contributor

Summary

This PR replaced the KResponsiveWindow to useKResponsiveWindow in (kolibri/plugins/perseus_viewer)

References

#11329

Reviewer guidance


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@im-NL
Copy link
Contributor

im-NL commented Oct 16, 2023

@ShivangRawat30 For the failling linting check, run yarn run lint-frontend:format in your cli, and then push the file you've edited again, the changes will be reflected here automatically. The linting checks should then pass.

@MisRob MisRob requested a review from LianaHarris360 October 16, 2023 10:50
@MisRob MisRob added the TODO: needs review Waiting for review label Oct 16, 2023
Copy link
Member

@LianaHarris360 LianaHarris360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look correct, once the lint-frontend:format command is ran in your cli and the linting checks pass, this PR can be approved.

Signed-off-by: shivangrawat30 <[email protected]>
@ShivangRawat30
Copy link
Contributor Author

@LianaHarris360 done

@LianaHarris360 LianaHarris360 merged commit c1b39b7 into learningequality:develop Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants