Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regression test and fix for empty querysets being passed to get_content_nodes_data #11490

Merged

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Nov 2, 2023

Summary

  • It is possible with partial metadata import for empty querysets to get generated during our file import queries
  • Fixes this by doing a defensive check for the queryset being empty (by checking the aggregations return any value)
  • Adds a regression test to ensure this behaviour

References

Fixes #11488

Reviewer guidance

Check the test. See the test pass. Rejoice!


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles requested review from bjester and jredrejo November 2, 2023 23:16
@rtibbles rtibbles added the TODO: needs review Waiting for review label Nov 2, 2023
@github-actions github-actions bot added DEV: backend Python, databases, networking, filesystem... and removed TODO: needs review Waiting for review labels Nov 2, 2023
@bjester bjester merged commit 6d0bf54 into learningequality:release-v0.16.x Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: backend Python, databases, networking, filesystem... SIZE: small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Content request download processing can result in an invalid query
2 participants