Include nodes for import that are missing supplementary files #11651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calculating nodes to import, only nodes that aren't available are included. However, a node is considered available if it's only missing supplementary files, so only nodes that aren't missing files should be filtered out of the import data.
github-actions
bot
added
DEV: backend
Build Artifacts
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When calculating nodes to import, only nodes that aren't available are included. However, a node is considered available if it's only missing supplementary files, so only nodes that aren't missing files should be filtered out of the import data.
References
Discussed on Slack with @rtibbles. What we're trying to do is mirror channels from Studio so that we can use it as a local cache when building OS images that contain preloaded Kolibri content. However, sometimes our channels have missing files despite repeatedly trying to import them from Studio. We tracked this down to supplementary files (thumbnails) that aren't being pulled from Studio when a channel is already present on the cache server.
Reviewer guidance
Import a channel and content, delete a thumbnail file, scan the content so it gets marked as unavailable, then import the channel content again. The thumbnail won't be downloaded again.
Testing checklist
PR process
Reviewer checklist
yarnandpip)