Sanitize inputs to handle NULL characters when parsing a string literal #11660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
DEV: backend
Build Artifacts
|
kolibri/core/auth/api.py
Outdated
|
|
||
| serializer = SanitizeInputsSerializer(data=request.data) | ||
| serializer.is_valid(raise_exception=True) | ||
| if not serializer.is_valid(): |
There was a problem hiding this comment.
This second validity check for the serializer can be removed. If the validation fails, it will automatically raise an exception due to serializer.is_valid(raise_exception=True), so the code inside this if block would not be executed.
There was a problem hiding this comment.
Sure @LianaHarris360. I'll update it.
LianaHarris360
approved these changes
Dec 19, 2023
There was a problem hiding this comment.
Thank you for working on this @KshitijThareja! The changes are as requested and now sanitize and validate the inputs before checking if the username already exists.
LianaHarris360
merged commit 6336620
into
learningequality:release-v0.16.x
33 checks passed
|
Thanks @LianaHarris360. I'm glad that the changes were as expected and helped solve the issue 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR aims to sanitize the username and facility inputs from
Create Accountpage by passing them through a serializer so as to avoid NULL characters and use the validated data from the serializer.References
#10505
Testing checklist
PR process
Reviewer checklist
yarnandpip)