Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use consistent KDS imports across the whole Kolibri #11742

Merged
merged 5 commits into from
Jan 26, 2024

Conversation

PR4NJ41
Copy link
Contributor

@PR4NJ41 PR4NJ41 commented Jan 18, 2024

This PR addresses the goal of standardizing Kolibri Design System (KDS) logic imports across the codebase. The approach is to import KDS Components directly instead of using Core API.

This PR solves the issue #11561.

References

Please see Issue #11561 and #5488

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added DEV: renderers HTML5 apps, videos, exercises, etc. APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) APP: Facility Re: Facility App (user/class management, facility settings, csv import/export, etc.) APP: Learn Re: Learn App (content, quizzes, lessons, etc.) APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) APP: Setup Wizard Re: Setup Wizard (facility import, superuser creation, settings, etc.) DEV: frontend SIZE: small labels Jan 18, 2024
@MisRob MisRob requested review from MisRob and rtibbles January 18, 2024 13:20
@MisRob MisRob self-assigned this Jan 18, 2024
Copy link
Member

@MisRob MisRob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @PR4NJ41, all good. Code changes make sense and haven't noticed any issues while navigating Kolibri. Just leaving one small note that'd be good to address before merging.

kolibri/core/assets/src/core-app/apiSpec.js Outdated Show resolved Hide resolved
@PR4NJ41 PR4NJ41 requested a review from MisRob January 24, 2024 16:15
Copy link
Member

@MisRob MisRob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @PR4NJ41, all good.

I don't think that the documentation check failure is related to this work. I will look into it first though before merging pull requests.

@rtibbles
Copy link
Member

@MisRob yes, the build failure is fixed in develop, and is not caused by this PR, so we can merge this!

Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@rtibbles rtibbles merged commit cc75a0b into learningequality:develop Jan 26, 2024
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) APP: Facility Re: Facility App (user/class management, facility settings, csv import/export, etc.) APP: Learn Re: Learn App (content, quizzes, lessons, etc.) APP: Setup Wizard Re: Setup Wizard (facility import, superuser creation, settings, etc.) DEV: frontend DEV: renderers HTML5 apps, videos, exercises, etc. SIZE: small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants