-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use consistent KDS imports across the whole Kolibri #11742
Conversation
Build Artifacts
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @PR4NJ41, all good. Code changes make sense and haven't noticed any issues while navigating Kolibri. Just leaving one small note that'd be good to address before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @PR4NJ41, all good.
I don't think that the documentation check failure is related to this work. I will look into it first though before merging pull requests.
@MisRob yes, the build failure is fixed in develop, and is not caused by this PR, so we can merge this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
This PR addresses the goal of standardizing Kolibri Design System (KDS) logic imports across the codebase. The approach is to import KDS Components directly instead of using Core API.
This PR solves the issue #11561.
References
Please see Issue #11561 and #5488
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)