Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent learner only devices from being shown as an import source when creating one. #11756

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Jan 19, 2024

Summary

Prevents us from showing subset of user devices when importing learner(s) to create a subset of user device

References

Fixes #11749

Reviewer guidance

Startup an already provisioned learner only device
Startup a fresh Kolibri env with this fix
Go through the learner only device flow
See that the already provisioned learner only device does not show up in the device selection modal


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added the TODO: needs review Waiting for review label Jan 19, 2024
@github-actions github-actions bot added APP: Setup Wizard Re: Setup Wizard (facility import, superuser creation, settings, etc.) DEV: frontend SIZE: very small labels Jan 19, 2024
Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@rtibbles
Copy link
Member Author

Will wait on manual QA to merge.

@radinamatic
Copy link
Member

Other LoDs and confusing strings are no more! 💥

2024-01-20_00-50-55

Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual QA passes, good to go! 💯 :shipit:

@rtibbles rtibbles merged commit e80feb9 into learningequality:release-v0.16.x Jan 19, 2024
34 checks passed
@rtibbles rtibbles deleted the soud_o_facilities branch January 19, 2024 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Setup Wizard Re: Setup Wizard (facility import, superuser creation, settings, etc.) DEV: frontend SIZE: very small TODO: needs review Waiting for review
Projects
None yet
3 participants