-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent learner only devices from being shown as an import source when creating one. #11756
Merged
rtibbles
merged 2 commits into
learningequality:release-v0.16.x
from
rtibbles:soud_o_facilities
Jan 19, 2024
Merged
Prevent learner only devices from being shown as an import source when creating one. #11756
rtibbles
merged 2 commits into
learningequality:release-v0.16.x
from
rtibbles:soud_o_facilities
Jan 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
APP: Setup Wizard
Re: Setup Wizard (facility import, superuser creation, settings, etc.)
DEV: frontend
SIZE: very small
labels
Jan 19, 2024
nucleogenesis
approved these changes
Jan 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM
Will wait on manual QA to merge. |
Build Artifacts
|
radinamatic
approved these changes
Jan 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manual QA passes, good to go! 💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
APP: Setup Wizard
Re: Setup Wizard (facility import, superuser creation, settings, etc.)
DEV: frontend
SIZE: very small
TODO: needs review
Waiting for review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Prevents us from showing subset of user devices when importing learner(s) to create a subset of user device
References
Fixes #11749
Reviewer guidance
Startup an already provisioned learner only device
Startup a fresh Kolibri env with this fix
Go through the learner only device flow
See that the already provisioned learner only device does not show up in the device selection modal
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)