useFetchTree specs #11766
Merged
useFetchTree specs #11766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nucleogenesis
added
TODO: needs review
github-actions
bot
added
APP: Coach
Build Artifacts
|
rtibbles
reviewed
Jan 24, 2024
rtibbles
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To streamline the process of getting realistic fixtures I just copied and pasted suitable raw API responses.
The one thing I've not covered is that the
loadingstate changes during the fetch. I tried mocking@vueuse/corew/ a factory function returning ajest.fnfor thesetto check that it had been called with a value but ran into trouble with it because we're actually setting_loadingand not theloadingcomputed property. Maybe some kind of spy trickery could be used here but ultimately I didn't want to bang my head on it too much.Covers the basics of fetching the tree, fetching more, and fetching a tree which doesn't have any more.
References
Marks one item complete in #11741
Reviewer guidance
Should anything else be covered here?