-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade KDS from v2.0.0 to v3.0.1 on the release branch #11929
Conversation
Hi @pcenov / @radinamatic, would you have a moment one more time to confirm that radio buttons at a few (any) places in Kolibri still work well? This is the same update we did some time ago here #11873, but on the release branch. |
Build Artifacts
|
d026d18
to
6a1ab49
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code changes are good, I didn't see any areas that were forgotten.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No changes noticed in the pages with radio buttons, nor any other regression noted when installing assets from this PR. Tested on Ubuntu 20.04 and Windows 10 (Firefox and Chrome). Good to go! 💯 👍🏽
Summary
Release notes
Includes Kolibri code updates related to the breaking change in regards to
value
-->buttonValue
renaming.Reviewer guidance
value
-->buttonValue
value
was indeed to use it as a prop to set the radio button's value HTML attribute (rather than as Vue value binding - in such cases it should stay:value
)Testing checklist
PR process
Reviewer checklist
yarn
andpip
)