Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quiz creation: Question replacement & a bevy of misc fixes and polish #11937

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
67 commits
Select commit Hold shift + click to select a range
dfeea15
questions are replaced successfully & select all logic fixed
nucleogenesis Feb 23, 2024
229d8c2
fix checkbox logic on replacement list
nucleogenesis Feb 26, 2024
1991ef7
breadcrumbs polish
nucleogenesis Feb 26, 2024
61675d8
channels link breadcrumbs works properly
nucleogenesis Feb 26, 2024
7dd656f
side panel doesn't open if the section_id in the URL is bad
nucleogenesis Feb 26, 2024
c5e6af9
show questions in replacements accordions
nucleogenesis Feb 26, 2024
218df74
active & replacement question pools in useQuizCreation
nucleogenesis Feb 13, 2024
e2fb1c4
update x of y replacements selected string
nucleogenesis Feb 13, 2024
cad04b3
remove unused style
nucleogenesis Feb 13, 2024
77a4084
add counter_in_exercise to question titles in main accordion
nucleogenesis Feb 13, 2024
94178e5
replace import/export lost in rebase
nucleogenesis Feb 27, 2024
8624302
SectionEditor styles tweaks
nucleogenesis Feb 27, 2024
c7c3c58
checkbox cleanup in reploacement
nucleogenesis Feb 29, 2024
1dab3c1
align "Add section" button
nucleogenesis Feb 29, 2024
c784ee2
misc style updates, fix duplicate back arrow in side panel
nucleogenesis Feb 29, 2024
d67e319
fix delete section in section editor; add
nucleogenesis Mar 3, 2024
6cb417d
update & clean-up strings; replace ConfirmCancellationModal w/ KModals
nucleogenesis Mar 3, 2024
5e89cd5
back arrow & x on resource selection
nucleogenesis Mar 3, 2024
dd80271
basic general snackbar messages
nucleogenesis Mar 4, 2024
1f7f9be
additional snackbar message
nucleogenesis Mar 4, 2024
9b991bf
ensure "no results" message shows when search yields nothing
nucleogenesis Mar 4, 2024
1bce015
fix missing styles on bottom-nav of replace questions; snackbars for …
nucleogenesis Mar 4, 2024
82e3fd2
correct messaging for close confirmation select resources
nucleogenesis Mar 4, 2024
d0f9ad4
handle clicking outside of modal as closing side panel
nucleogenesis Mar 4, 2024
642b250
fix sidepanelmodal breakpoint for when it would go into mobile-mode
nucleogenesis Mar 4, 2024
e84f7ab
fix number of resources on section editor
nucleogenesis Mar 5, 2024
c73ed36
fix browser nav issues w/ showBookmarks
nucleogenesis Mar 5, 2024
39885ab
styles updates & message update
nucleogenesis Mar 5, 2024
69e855f
spacing fix
nucleogenesis Mar 5, 2024
3fed2b3
proper message on side panel back/close button
nucleogenesis Mar 5, 2024
bd5e2de
outline-offset on section tabs fix
nucleogenesis Mar 5, 2024
bde269c
move exported method inline
nucleogenesis Mar 7, 2024
a23598e
make leaf content nodes not clickable or focusable
nucleogenesis Mar 7, 2024
2619153
move cursor CSS change to /deep/ selector
nucleogenesis Mar 7, 2024
c345839
include `aria-selected` indicator on accordion-item and content card …
nucleogenesis Mar 7, 2024
4e0e7e6
comment on deep selector for section tabs
nucleogenesis Mar 7, 2024
2c340a6
comment clarifying ReplaceQuestions#beforeRouteLeave
nucleogenesis Mar 7, 2024
cef5f45
section tabs have tabindex set to 0; keyboad focus fix from options d…
nucleogenesis Mar 8, 2024
7e187d4
move 'can we try to replace' logic to computed prop, disable Replace …
nucleogenesis Mar 11, 2024
db06ddf
fix & improve replacements KCheckbox handling
nucleogenesis Mar 11, 2024
1757bb7
fix checkbox console errors; allQuestionsSelected now returns Boolean…
nucleogenesis Mar 11, 2024
e9528e9
accidental merge removed
nucleogenesis Mar 15, 2024
34902a2
move bookmarks exercise filter to where the value is set
nucleogenesis Mar 18, 2024
82a70bc
confirm replacement message
nucleogenesis Mar 18, 2024
66fa6b1
don't ask for confirmation when going to select-resources from sectio…
nucleogenesis Mar 18, 2024
b3af86d
selectQuestions new param "excludes" to avoid selecting questions alr…
nucleogenesis Mar 18, 2024
2d09bc0
clarify/clean up calls to selectQuestions
nucleogenesis Mar 18, 2024
ba05b3c
use a unique id in place of question_id throughout quiz creation
nucleogenesis Mar 18, 2024
760327e
update delimiter for unique question id
nucleogenesis Mar 21, 2024
f3310e2
fixes for questions management edge cases; fix showing preview (as be…
nucleogenesis Mar 27, 2024
6b09a5a
conditional label for resource change button in section editor
nucleogenesis Mar 27, 2024
236d309
update questions more reliably
nucleogenesis Mar 27, 2024
531d375
use unique_id_arrays while generating list of activequestions
nucleogenesis Mar 29, 2024
85c20b7
remove unnecessary select questions test
nucleogenesis Mar 29, 2024
f8a690a
update homehydrate viewset to account for Exam v3
nucleogenesis Mar 29, 2024
7e8c4a3
use proper node id for exercise_id, proper data_model property in exa…
nucleogenesis Apr 2, 2024
00de4e8
use exam_assignment_lookup for cleaner itearator
nucleogenesis Apr 2, 2024
fac5ef7
use exam_assignment_lookup throughout as it is itself backwardcompatible
nucleogenesis Apr 4, 2024
843271d
remove outdated/unnecessary DEBUG functionality from useQuizCreation
nucleogenesis Apr 4, 2024
b600ee2
update quiz creation specs to clarify exercise_id origin
nucleogenesis Apr 9, 2024
5b1472e
add unique_question_ids to resources when they're saved in the first …
nucleogenesis Apr 9, 2024
0dda969
properly handle resource_pool, question and question_count updates
nucleogenesis Apr 9, 2024
e80c04b
better definition for QuizQuestion.id in specs
nucleogenesis Apr 9, 2024
f70e25c
update useQuizCreation spec data to accommodate unique IDs
nucleogenesis Apr 9, 2024
84a37a3
update og to original
nucleogenesis Apr 12, 2024
dbc342b
fix replacement contentrenderer id refs
nucleogenesis Apr 12, 2024
4cf2258
use question.id on ref to ensure uniqueness
nucleogenesis Apr 18, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions kolibri/plugins/coach/assets/src/composables/quizCreationSpecs.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,28 +9,28 @@
/**
* @typedef {Object} QuizExercise An object referencing an exercise or topic to be used
* within the `QuizSeciton.resource_pool` property.
* @property {string} id Unique ID for this exercise (aka, `exercise_id` elsewhere)
* @property {string} title The resource title
* @property {string} ancestor_id The ID of the parent contentnode
* @property {string} content_id The ID for the piece of content
* @property {string} id Unique ID for this exercise
* @property {bool} is_leaf Whether or not this is a leaf node (i.e. an exercise)
* @property {string} kind Exercise or Topic in our case - see: `ContentNodeKinds`
*/

export const QuizExercise = {
title: {
id: {
type: String,
default: '',
},
ancestor_id: {
title: {
type: String,
default: '',
},
content_id: {
ancestor_id: {
type: String,
default: '',
},
id: {
content_id: {
type: String,
default: '',
},
Expand All @@ -55,6 +55,8 @@ export const QuizExercise = {
/**
* @typedef {Object} QuizQuestion A particular question in a Quiz - aka an assessment item
* from an QuizExercise.
* @property {string} id A ** unique ** identifier for this question that is
* a combination of <exercise_id>:<question_id>
* @property {string} exercise_id The ID of the resource from which the question originates
* @property {string} question_id A *unique* identifier of this particular question within
* the quiz -- same as the `assessment_item_id`
Expand All @@ -63,6 +65,10 @@ export const QuizExercise = {
* same exercise title to differentiate them
*/
export const QuizQuestion = {
id: {
type: String,
required: true,
},
exercise_id: {
type: String,
required: true,
Expand Down
Loading