Overrides prop default flipping behaviour

[kafukoM]

Summary

This pull request extends the enhancements introduced in the recent KDS component update addressing this issue (learningequality/kolibri-design-system#432). It adjusts the constrainToScrollParent prop of the KDropdownMenu component within Kolibri. Previously, we updated the KDropdownMenu in the KDS repo to support a new prop allowing for more flexible dropdown positioning. This PR leverages that enhancement in Kolibri by setting constrainToScrollParent to false for a specific instance (Facility Settings template) of KDropdownMenu, ensuring that the dropdown always displays downwards, improving UX under specific layout conditions.

…

References

Issue in KDS - learningequality/kolibri-design-system#432
PR in KDS - learningequality/kolibri-design-system#586

…

Reviewer guidance

Steps to test

Go to Facility
Click Settings
Scroll down and create PIN if non-existent
Click Options button

…

---

Testing checklist

• Contributor has fully tested the PR manually
• If there are any front-end changes, before/after screenshots are included
• Critical user journeys are covered by Gherkin stories
• Critical and brittle code paths are covered by unit tests

PR process

• PR has the correct target branch and milestone
• PR has 'needs review' or 'work-in-progress' label
• If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
• If this is an important user-facing change, PR or related issue has a 'changelog' label
• If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

• Automated test coverage is satisfactory
• PR is fully functional

[kafukoM]

@akolson @MisRob Kindly requesting for a review

[akolson]

This change looks correct to me. Thanks @kafukoM.
I'll however add a blocker as this should only be merged after learningequality/kolibri-design-system#586 is merged and a new kds npm package published. Also, the KDS version in your pr should be updated accordingly before the merge.

@MisRob please be sure to let me know whenever the npm release from this fix is ready so this can be updated and merged as well. Thanks

[github-actions]

Build Artifacts

Asset type	Download link
PEX file	kolibri-.pex
Windows Installer (EXE)	kolibri-0.16.1.dev0+git.20240403081042-unsigned.exe
Debian Package	kolibri_0.16.1.dev0+git.20240403081042-0ubuntu1_all.deb
Mac Installer (DMG)	kolibri-0.16.1.dev0+git.20240403081042-0.4.0.dmg
Android Package (APK)	kolibri-0.16.1.dev0+git.20240403081042-0.1.0-debug.apk
TAR file	kolibri-0.16.1.dev0+git.20240403081042.tar.gz
WHL file	kolibri-0.16.1.dev0+git.20240403081042-py2.py3-none-any.whl

[MisRob]

@akolson I will release it by the beginning of next week

[akolson]

Thanks @MisRob!

[akolson]

Hi @kafukoM, could you please update the KDS version of this pr to 3.1.1 so we can have manual QA on it?

kolibri/kolibri/core/package.json

Line 24 in 3490eac

"kolibri-design-system": "3.0.1",

[akolson]

Please remember to run yarn install and test it. Let me know when ready so I can tag manual QA. Feel free to add images, videos so QA is able to better understand what was fixed. Thanks

[kafukoM]

Hello @akolson. I have made the requested changes to the package.json file.

[akolson]

This looks correct me. Tagging QA to have a look before the merge. Thanks @kafukoM!

[pcenov]

Thanks @kafukoM - I confirm that this is implemented as specified and there are no issues observed while manually testing the drop-down.

[akolson]

Thanks @pcenov @kafukoM.