Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#12028 introduced a regression due to a copy paste error by me, that tried to use query_params inside a POST request.
Reverts back to data.
References
Fixes #12048
Reviewer guidance
Start with a fresh KOLIBRI_HOME
Use the On My Own workflow
Create a user whose username already exists on a remote facility
Complete setup
Go to user profile
Change Learning Facility
Go through the steps to merge your user with the existing user
Rejoice when it works.
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)