Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix URL handling regression #12049

Merged

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Apr 3, 2024

Summary

#12028 introduced a regression due to a copy paste error by me, that tried to use query_params inside a POST request.
Reverts back to data.

References

Fixes #12048

Reviewer guidance

Start with a fresh KOLIBRI_HOME
Use the On My Own workflow
Create a user whose username already exists on a remote facility
Complete setup
Go to user profile
Change Learning Facility
Go through the steps to merge your user with the existing user
Rejoice when it works.


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles requested a review from marcellamaki April 3, 2024 17:27
@rtibbles rtibbles added this to the Kolibri 0.16: Planned Patch 1 milestone Apr 3, 2024
@github-actions github-actions bot added DEV: backend Python, databases, networking, filesystem... APP: User Re: User app (sign-in, sign-up, user profile, etc.) SIZE: very small labels Apr 3, 2024
Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Richard - this looks like the right fix. I'm going to merge and include in a beta2 for Peter's review tomorrow

@marcellamaki marcellamaki merged commit fc83f79 into learningequality:release-v0.16.x Apr 3, 2024
34 checks passed
@pcenov
Copy link
Member

pcenov commented Apr 4, 2024

I confirm - the issue described in #12048 is fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: User Re: User app (sign-in, sign-up, user profile, etc.) DEV: backend Python, databases, networking, filesystem... SIZE: very small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants