Add --manifest-only option to exportcontent command #12059
Conversation
github-actions
bot
added
the
DEV: backend
thesujai
changed the title
|
I need to add tests here |
| logger.info( | ||
| "Exporting content for channel id {} to {}".format(channel_id, data_dir) | ||
| ) | ||
| exported_files = [] |
There was a problem hiding this comment.
How about moving this copying part to a separate method? It will be more readable
There was a problem hiding this comment.
Alright will do that!
Build Artifacts
|
There was a problem hiding this comment.
This looks like the right change so far! Agree with the small refactor, and this will be good to go with a couple of tests.
See this class for existing tests for this management command, additional tests can be added there! https://github.com/learningequality/kolibri/blob/develop/kolibri/core/content/test/test_import_export.py#L2176
| logger.info( | ||
| "Exporting content for channel id {} to {}".format(channel_id, data_dir) | ||
| ) | ||
| exported_files = [] |
|
I have included with tests as well |
| logger.info( | ||
| "Exporting content for channel id {} to {}".format(channel_id, data_dir) | ||
| ) | ||
| exported_files = [] |
There was a problem hiding this comment.
I know you copy pasted this from the original implementation - but it seems like this exported_files value is not actually used? Feels like we could remove it and stop collecting the list if it's unused. At a minimum, it will slightly reduce memory usage.
| "exportcontent", self.the_channel_id, tempfile.mkdtemp(), manifest_only=True | ||
| ) | ||
|
|
||
| copy_content_files_mock.assert_not_called() |
There was a problem hiding this comment.
Your refactor definitely makes asserting the behaviour here much simpler too!
|
Excellent work, thanks @thesujai! |
Summary
Adds a new
--manifest-onlyoption to just export the manifest.json file instead of entire content data in theexportcontentcommandReferences
Fixes #10384
Reviewer guidance
Run the below command:
Observe only manifest.json getting generated, contrary to above command being used without
--manifest-onlywhich will also generate contentTesting checklist
PR process
Reviewer checklist
yarnandpip)